Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007627OCamldocumentationpublic2017-09-15 02:382017-09-15 12:44
Reporterfuruse 
Assigned Tolpw25 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version4.05.0 
Target Version4.06.0 +dev/beta1/beta2/rc1Fixed in Version4.06.0 +dev/beta1/beta2/rc1 
Summary0007627: 4.06.0 Change : Format change must be marked as breaking.
Description- Resurrect tabulation boxes in module Format. Rewrite/extend documentation
  of tabulation boxes.

This changes the signature of Format and several applications which improve Format by themselves such as spotlib and omake fail to compile in 4.06.0+trunk.

The changes themselves are ok but please mark it as a breaking change.

TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0018256)
gasche (administrator)
2017-09-15 07:09

So the problem is that the commit

  https://github.com/ocaml/ocaml/commit/c9cc0f25138ce58e4f4e68c4219afe33e2a9d034 [^]

removed the pp_* versions of the tabulation boxes functions.

I don't understand why this was done, we need to ask the format maintainers. Maybe it is possible to restore these functions to restore compatibility.

(Octachron noticed this in https://github.com/ocaml/ocaml/pull/1291 [^] but he was too shy to complain about it.)
(0018257)
lpw25 (developer)
2017-09-15 10:04

I already asked the maintainers on the devel list. It was an accident. I'm making a pull request to put them back now.
(0018258)
lpw25 (developer)
2017-09-15 10:12

https://github.com/ocaml/ocaml/pull/1337 [^]
(0018259)
gasche (administrator)
2017-09-15 11:16

Fixed by Leo in the PR above.
(0018260)
furuse (reporter)
2017-09-15 12:44

Thanks. Please note that I am also too shy to complain about the change made by my thesis advisor.

- Issue History
Date Modified Username Field Change
2017-09-15 02:38 furuse New Issue
2017-09-15 07:09 gasche Note Added: 0018256
2017-09-15 07:09 gasche Assigned To => gasche
2017-09-15 07:09 gasche Status new => confirmed
2017-09-15 07:09 gasche Target Version => 4.06.0 +dev/beta1/beta2/rc1
2017-09-15 10:04 lpw25 Note Added: 0018257
2017-09-15 10:12 lpw25 Note Added: 0018258
2017-09-15 11:16 gasche Note Added: 0018259
2017-09-15 11:16 gasche Status confirmed => resolved
2017-09-15 11:16 gasche Fixed in Version => 4.06.0 +dev/beta1/beta2/rc1
2017-09-15 11:16 gasche Resolution open => fixed
2017-09-15 11:16 gasche Assigned To gasche => lpw25
2017-09-15 12:44 furuse Note Added: 0018260


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker