You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 7652 Reporter:@dra27 Assigned to:@alainfrisch Status: resolved (set by @alainfrisch on 2017-10-26T12:46:16Z) Resolution: fixed Priority: normal Severity: minor Version: 4.06.0 +dev/beta1/beta2/rc1 Target version: 4.06.0 +dev/beta1/beta2/rc1 Category: runtime system and C interface Monitored by:@gasche
Bug description
#71 (#71) deprecated caml_strdup but the symbol is only defined if CAML_INTERNALS is defined, which breaks any non-OCaml C stubs using it.
I'm not completely sure, but I don't think that the fix for this is to move the #define outside a CAML_INTERNALS block.
There is a discussion in the GPR about the removal of caml_strdup - skimming through it, it's possible that what should change is documentation to show that we removed caml_strdup and that code should be updated to use caml_stat_strdup (with any corresponding free call changed to caml_stat_free). Max's analysis of opam seemed to suggest that correct usage of caml_strdup which very limited.
dra, let's move on with the plan of properly documenting the breakage (first, is "caml_strdup" present in a star-marked Changes entry ? If not, maybe we could create one pointing at #71, or at least add it to the GPR's existing entry). Would you be able to submit a PR for this shortly?
Putting those aliases into CAML_INTERNALS was not intentional, and is likely an artefact of a sloppy rebase. There should be no breakage in the client code, unless the runtime is started with caml_startup_pooled (which requires that caml_stat_* blocks are only disposed with caml_stat_free).
Original bug ID: 7652
Reporter: @dra27
Assigned to: @alainfrisch
Status: resolved (set by @alainfrisch on 2017-10-26T12:46:16Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.06.0 +dev/beta1/beta2/rc1
Target version: 4.06.0 +dev/beta1/beta2/rc1
Category: runtime system and C interface
Monitored by: @gasche
Bug description
#71 (#71) deprecated caml_strdup but the symbol is only defined if CAML_INTERNALS is defined, which breaks any non-OCaml C stubs using it.
Additional information
#71 (review)
The text was updated successfully, but these errors were encountered: