Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error during compilation with 4.05.0+flambda #7714

Closed
vicuna opened this issue Jan 21, 2018 · 4 comments
Closed

error during compilation with 4.05.0+flambda #7714

vicuna opened this issue Jan 21, 2018 · 4 comments
Labels
bug middle-end

Comments

@vicuna
Copy link

vicuna commented Jan 21, 2018

Original bug ID: 7714
Reporter: @c-cube
Status: resolved (set by @xavierleroy on 2018-06-20T14:12:21Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: linux
Version: 4.05.0
Fixed in version: 4.07.0+dev/beta2/rc1/rc2
Category: middle end (typedtree to clambda)
Monitored by: @nojb @gasche

Bug description

I've got a compilation error in flambda when I compile the benchmarks of containers:

Fatal error: Missing renaming for specialised argument of a function being duplicated but not directly applied: add_list_/473936 -> add_list_/473334(=
(move_within_set_of_closures
CCHashTrie.add_list__surrogate/3068 <-- CCHashTrie.add_list_/811
(closure = add_list_/473937))).

See attached log of the build failure for more details. I've got the same error in 4.06.0+flambda.

Steps to reproduce

git clone https://github.com/c-cube/ocaml-containers
cd ocaml-containers
git checkout 7df23d0ccaf9e9d36455f8ca1a2db959e6e1f868
opam install jbuilder gen sequence qcheck benchmark
make benchs

File attachments
@vicuna
Copy link
Author

vicuna commented Jan 22, 2018

Comment author: @lpw25

We've seen this bug once at Janestreet. There is a fix for it mixed in with the changes in:

#1343

Xavier Clerc was working on a stand-alone PR for it the other day, so there should be a fix merged pretty soon.

@vicuna
Copy link
Author

vicuna commented Jun 9, 2018

Comment author: @xavierleroy

Can you please confirm this has been fixed and in which version? (4.06, 4.07?)

@vicuna
Copy link
Author

vicuna commented Jun 20, 2018

Comment author: @nojb

I confirm this is NOT fixed in 4.06.1.

Could not get the repro instruction to work with 4.07, so could not check if it is fixed there or not.

@vicuna
Copy link
Author

vicuna commented Jun 20, 2018

Comment author: @lpw25

That PR was merged in 4.07. So hopefully it is fixed there.

@vicuna vicuna closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug middle-end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna