New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated annotation on let-binding does not trigger #7719
Comments
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
This bug is still present and relevant. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
The people who have looked most at alerts and warnings, and might look at this, are @alainfrisch and @lpw25. i don't know if other contributors ( @antalsz, @nchataing, @Drup ) would be interested in looking at it. |
After some investigation, what comes clear is the fact that The following code will hence emit the desired warning : |
After some thinking, one possible fix would be to propagate the |
In As @nchataing mentioned, there is a syntax which works, and I'm tempted to believe that marking some components as deprecated within an implementation is rare enough (I've only seen case of deprecation markers in module signatures), so I'm not sure something needs to be fixed. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
Original bug ID: 7719
Reporter: authchir
Status: new
Resolution: open
Priority: normal
Severity: minor
Platform: amd64
OS: linux
OS Version: 4.4.0-43-Microso
Version: 4.06.0
Category: compiler driver
Monitored by: @nojb @gasche
Bug description
As explored in this [Stackoverflow question][1], a let-binding annotated with a
deprecated
annotation does not trigger any warning. But the annotation on type definition and constructors does work.[1] https://stackoverflow.com/q/48579580/823955
Steps to reproduce
Given the following file
main.ml
:The compilation output two warnings, while three would be expected:
The text was updated successfully, but these errors were encountered: