Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols mentioned in compatibility.h but not declared anywhere else #7744

Closed
vicuna opened this issue Feb 23, 2018 · 3 comments
Closed

Symbols mentioned in compatibility.h but not declared anywhere else #7744

vicuna opened this issue Feb 23, 2018 · 3 comments
Labels
Stale
Milestone
4.07.0

Comments

@vicuna
Copy link

vicuna commented Feb 23, 2018

Original bug ID: 7744
Reporter: @dra27
Status: new
Resolution: open
Priority: normal
Severity: tweak
Version: 4.06.1
Target version: 4.07.0+dev/beta2/rc1/rc2
Category: runtime system and C interface
Monitored by: @nojb

Bug description

The following symbols are declared in compatibility.h and marked CAMLexport in the runtime but are only defined in their respective C files: caml_channel_size, caml_do_read, caml_finalize_channel, caml_input_scan_line, caml_int32_ops, caml_int64_ops, caml_minor_collection, caml_nativeint_ops, caml_pos_in, caml_pos_out, caml_seek_in, caml_seek_out.

Steps to reproduce

caml_minor_collection, judging from the comment, exists for lablgtk?

caml_pos_in, caml_pos_out, caml_seek_in and caml_seek_out are marked special cases in compatibility.h

Note that while caml_int32_ops, caml_int64_ops and caml_nativeint_ops have been marked CAMLexport, caml_ba_ops never has been.

The remaining items (also) come from io.c and, again judging from comments, appear to have been exported for Cash's benefit?

Additional information

Possible change on the horizon where symbols need once again to be exported explicitly, so these need to be properly mentioned in headers if they're to be kept exported.
@vicuna vicuna added the stdlib label Mar 14, 2019
@vicuna vicuna added this to the 4.07.0 milestone Mar 14, 2019
@github-actions github-actions bot added the Stale label May 7, 2020
@dra27
Copy link
Member

dra27 commented May 7, 2020

Cross reference #1633

@dra27 dra27 removed the Stale label May 7, 2020
@ocaml ocaml deleted a comment from github-actions bot Sep 4, 2020
@dra27 dra27 removed the stdlib label Sep 4, 2020
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label Sep 6, 2021
@dra27
Copy link
Member

dra27 commented Sep 6, 2021

@dra27 dra27 closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
4.07.0
Development

No branches or pull requests
2 participants
@dra27 @vicuna