Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-prefixed symbol name (and non-standard prefixed names) in the debug and instrumentation runtimes #7814

Closed
vicuna opened this issue Jun 26, 2018 · 2 comments
Closed

non-prefixed symbol name (and non-standard prefixed names) in the debug and instrumentation runtimes #7814

vicuna opened this issue Jun 26, 2018 · 2 comments
Assignees
@damiendoligez
Labels
bug stdlib
Milestone
4.08

Comments

@vicuna
Copy link

vicuna commented Jun 26, 2018

Original bug ID: 7814
Reporter: @gasche
Assigned to: @damiendoligez
Status: resolved (set by @alainfrisch on 2018-07-16T08:56:10Z)
Resolution: fixed
Priority: low
Severity: minor
Version: 4.07.0+dev/beta2/rc1/rc2
Target version: 4.08.0+dev/beta1/beta2
Fixed in version: 4.08.0+dev/beta1/beta2
Category: runtime system and C interface
Monitored by: @nojb

Bug description

After world.opt is built:

$ ./tools/check-symbol-names asmrun/.a byterun/.a
asmrun/libasmruni.a[misc.i.o]: CAML_INSTR_ATEXIT T
asmrun/libasmruni.a[misc.i.o]: CAML_INSTR_INIT T
asmrun/libasmruni.a[misc.i.o]: CAML_INSTR_LOG B
asmrun/libasmruni.a[misc.i.o]: CAML_INSTR_STARTTIME C
asmrun/libasmruni.a[misc.i.o]: CAML_INSTR_STOPTIME C
byterun/libcamlrund.a[instrtrace.d.o]: names_of_instructions D
byterun/libcamlruni.a[misc.i.o]: CAML_INSTR_ATEXIT T
byterun/libcamlruni.a[misc.i.o]: CAML_INSTR_INIT T
byterun/libcamlruni.a[misc.i.o]: CAML_INSTR_LOG B
byterun/libcamlruni.a[misc.i.o]: CAML_INSTR_STARTTIME C
byterun/libcamlruni.a[misc.i.o]: CAML_INSTR_STOPTIME C

We should probably prefix names_of_instructions.
We should also rename CAML_* into some caml_* -- or add CAML_* as another private namespace in tools/check-symbol-names.
@vicuna
Copy link
Author

vicuna commented Jun 26, 2018

Comment author: @xavierleroy

Alternatively, "names_of_instructions" could be made "static", as it is used only in the file that defines it (byterun/instrtrace.c).

@vicuna
Copy link
Author

vicuna commented Jul 12, 2018

Comment author: @damiendoligez

See #1900

@vicuna vicuna closed this as completed Jul 16, 2018
@vicuna vicuna added the stdlib label Mar 14, 2019
@vicuna vicuna added this to the 4.08.0 milestone Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
@nojb nojb modified the milestones: 4.08.0, 4.08 Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiendoligez damiendoligez

Labels
bug stdlib
Projects
None yet
Milestone
4.08
Development

No branches or pull requests
3 participants
@damiendoligez @nojb @vicuna