New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad error syntax on tuple with trailing comma #7858
Comments
Is this bug being handled by anyone? I would like to work on it if not. |
@AndrewLitteken: unfortunately, we don't have a good story for syntax error messages right now, and we are planning to change how they are done in a couple OCaml versions. I would encourage you to focus on some other task, because this one is likely to (1) turn out to be more difficult than it looks and (2) have the solution space change quite a bit in 6-12 months. |
Probably the same bug, but may be worth adding as a test case:
|
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
Still reproducible. |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
This has been partially fixed in #10095: The incorrect |
This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc. |
On 5.0.0 rc1, both |
Original bug ID: 7858
Reporter: @gasche
Assigned to: @let-def
Status: assigned (set by @gasche on 2018-10-03T13:14:59Z)
Resolution: open
Priority: normal
Severity: minor
Version: 4.08.0+dev/beta1/beta2
Target version: undecided
Category: lexing and parsing
Tags: syntax-error-messages
Monitored by: @nojb
Bug description
Consider the input "(foo,);;"
4.07.0 behaves as follows:
Trunk (4.08+dev) behaves as follows:
Both messages are bad, but arguably the new one is even worse.
The text was updated successfully, but these errors were encountered: