Comment author: @gasche

Nice catch. Would you like to provide a patch to fix this issue?

(It might be necessary to duplicate the fix for the native toplevel as well, see files toplevel/opttop*.)

Comment author: ggole

Hmm, is changing Filename.chop_extension to Filename.remove_extension sufficient? It seems as if that will avoid raising the exception.

The code (specifically parse_mod_use_file) seems a bit suspicious to me. A module name is supposed to be generated from a filename, but strings that are not sane module names such as "@%" are allowed. In fact, fairly sane filenames like "foo-bar.ml" will "work" and produce a module that the user will not be able to name in OCaml code - that doesn't seem right.

I would guess that a module name should be parsed after whacking off the filename parts?

Comment author: @gasche

For the record, the relevant code is:

let parse_mod_use_file name lb =
let modname =
String.capitalize_ascii (Filename.chop_extension (Filename.basename name))
in ...

Clearly the intent of the modname calculation is to turn a valid filename into a valid module name, and as you say it does not work very well. I don't think a robust logic exists to do this name munging inside the compiler (debugger/command_line.ml has similar but more robust logic in convert_module).

If you feel inspired to write something more robust, I think it could go into utils/misc.ml. If you don't, then I think at least getting rid of the failure here would be nice. Indeed Filename.remove_extension should be enough, I guess it did not exist at the time parse_mod_use_file was written.

Comment author: ggole

All right, I made a PR with that simple change.