caml_string_equal should be marked as @@noalloc #7874
Comments
|
Comment author: @gasche If you believe that it would be safe to use noalloc there, would you like to submit a Pull Request to do it? |
|
Comment author: @gasche (I suppose caml_string_compare could also be marked as such. I wonder why caml_string_equal is not using memcmp like caml_string_compare, is a loop faster?) |
|
Comment author: @ppedrot This is already done for caml_string_compare I believe, this function is treated as a primitive in the compiler and its interpretation reads Primitive.simple ~name:"caml_string_compare" ~arity:2 ~alloc:false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original bug ID: 7874
Reporter: @ppedrot
Assigned to: @nojb
Status: resolved (set by @nojb on 2018-11-21T19:44:13Z)
Resolution: fixed
Priority: normal
Severity: tweak
Version: 4.07.1
Category: runtime system and C interface
Monitored by: @nojb
Bug description
Currently, String.equal is defined as a C stub without any annotation. It should be marked as noalloc, as it does not mess with the GC.
The text was updated successfully, but these errors were encountered: