Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused module open with override #7880

Closed
vicuna opened this issue Dec 2, 2018 · 1 comment
Closed

Unused module open with override #7880

vicuna opened this issue Dec 2, 2018 · 1 comment
Assignees
@lpw25
Labels
bug typing

Comments

@vicuna
Copy link

vicuna commented Dec 2, 2018

Original bug ID: 7880
Reporter: @hhugo
Assigned to: @lpw25
Status: closed (set by @lpw25 on 2018-12-02T14:31:46Z)
Resolution: not a bug
Priority: normal
Severity: minor
Category: typing

Bug description

Trying to compile base (from janestreet) with trunk, I get plenty of warning 66

File "lib/base/boot/stringable.ml", line 3, characters 0-12:
3 | open! Import
^^^^^^^^^^^^
Error (warning 66): unused open! Base_boot__.Import.
@vicuna
Copy link
Author

vicuna commented Dec 2, 2018

Comment author: @hhugo

I didn't realize this was intentional. #1110.
Can someone please close this issue.

@vicuna vicuna closed this as completed Dec 2, 2018
@vicuna vicuna added the typing label Mar 14, 2019
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpw25 lpw25

Labels
bug typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpw25 @vicuna