Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocamldoc generates rotate=90 directive in dot file, which is not correct #7888

Closed
vicuna opened this issue Dec 29, 2018 · 2 comments
Closed

Comments

@vicuna
Copy link

vicuna commented Dec 29, 2018

Original bug ID: 7888
Reporter: luc.bouge
Status: new
Resolution: open
Priority: normal
Severity: minor
Platform: Mac
OS: 10.14
Version: 4.07.1
Category: ocamldoc
Monitored by: @nojb

Bug description

I use ocamldoc 4.07.1+rc1.

I use it to generate a dependency graph for a set of modules, with the following command

ocamldoc -warn-error -I _build -dot *.ml -o graph.dot
dot -Tpdf graph.dot > graph.pdf

The generated dot file starts with:

digraph G {
size="10,7.5";
ratio="fill";
rotate=90;
fontsize="12pt";
rankdir = TB ;
...

However, the dot directive "rotate=90;" is not working on MacOS 10.14. With this directive, dot generates a blank page. See https://gitlab.com/graphviz/graphviz/issues/1434.

Without the directive, it works perfectly.

Steps to reproduce

I join the graph.dot file, as generated below.

$ ocamldoc --version
4.07.1+rc1

$ ocamldoc -warn-error -I _build -dot *.ml -o graph.dot

$ ls -la graph.dot
-rw-r--r--@ 1 bouge staff 1934 29 déc 11:02 graph.dot

$ dot -Tpdf graph.dot > graph.pdf

$ ls -la graph.pdf
-rw-r--r--@ 1 bouge staff 22539 29 déc 11:04 graph.pdf

$ open graph.pdf
--> Blank page

Additional information

You can test out this behavior of dot with this file:

$ more test.dot
digraph G {
rotate=90;
"a" -> "b";
}

$ dot -Tpdf test.dot > test.pdf

$ open test.pdf
--> Blank page

File attachments

@vicuna
Copy link
Author

vicuna commented Jan 9, 2019

Comment author: @Octachron

Is there a more conclusive indication that "rotate=90" is not correct? It seems valid according to graphviz grammar description and it works on at least one implementation. We could maybe add a bare option to ocamldoc dot output, but it would still require some manual hand editing.

@github-actions
Copy link

github-actions bot commented May 7, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 7, 2020
@github-actions github-actions bot closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant