Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comments about NaNs #7891

Closed
vicuna opened this issue Jan 2, 2019 · 1 comment · Fixed by #9536
Closed

Incorrect comments about NaNs #7891

vicuna opened this issue Jan 2, 2019 · 1 comment · Fixed by #9536

Comments

@vicuna
Copy link

vicuna commented Jan 2, 2019

Original bug ID: 7891
Reporter: sfuric
Status: new
Resolution: open
Priority: normal
Severity: minor
Version: 4.07.0
Category: documentation
Monitored by: @nojb @shindere @yakobowski

Bug description

Documentation of module Float is wrong regarding IEEE 754 evaluation rules. It says any arithmetic operation with nan as argument returns nan as result and Any floating-point operation with nan as argument returns nan as result which is wrong, as demonstrated by OCaml itself:

        OCaml version 4.07.0
# 1.0 ** nan;;
- : float = 1.
# nan ** 0.0;;
- : float = 1.
#
@github-actions
Copy link

github-actions bot commented May 6, 2020

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 6, 2020
Chris00 added a commit to Chris00/ocaml that referenced this issue May 6, 2020
xavierleroy pushed a commit that referenced this issue May 12, 2020
Fix documentation comment about NaN propagation

Closes: #7891

Co-authored-by: David Allsopp <david.allsopp@metastack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants