Use the autoconf- or system-provided off_t rather than redetecting. #8843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stedolan
force-pushed
the
use-off-t-directly
branch
from
1b261fb
to
90ad648
Compare
|
Patch looks sensible to me. |
|
cc @Octachron: would that be a candidate for 4.08.1? |
xavierleroy
approved these changes
Jul 29, 2019
|
Then let's backport this fix in 4.08.1 since a rc3 is already planned. |
|
I'm currently rebuilding the Fedora packages with this patch to see if there are any problems. |
stedolan
force-pushed
the
use-off-t-directly
branch
from
90ad648
to
8b85964
Compare
|
|
xavierleroy
pushed a commit
that referenced
this pull request
Jul 31, 2019
xavierleroy
pushed a commit
that referenced
this pull request
Jul 31, 2019
|
It looks fine, thanks! |
|
I'm (still) testing the Fedora ocaml packages. It's going much slower than I expected because our build system is having problems. |
|
Ok, I will wait a bit for the build result before releasing the rc3. |
|
I can confirm that this fixes the original bug (in supermin). |
|
Thanks for the confirmation! |
hannesm
added a commit
to hannesm/ocaml-freestanding
that referenced
this pull request
Aug 3, 2019
… by posix) since ocaml/ocaml#8843 (>= 4.08.1+rc3) off_t in sys/types.h is required
lpw25
pushed a commit
to janestreet/ocaml
that referenced
this pull request
Aug 13, 2019
…caml#8843) Fixes: ocaml#8841. Cherry-pick of commit 5e4b55d on trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a 64-bit file offset on a 32-bit system is broken in 4.08, because the use of
off_tis guarded byHAS_OFF_T, which is not defined by the configure script. (It's mentioned in configure.ac, but there's no corresponding template line ins.h.in).As suggested by @rwmjones in #8841, this just uses
off_tunconditionally. (Except on Windows, whereoff_tis weird and broken).